feat(cz_check): cz check can read commit message from pipe #267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 96.60% 96.62% +0.02%
==========================================
Files 33 33
Lines 912 919 +7
==========================================
+ Hits 881 888 +7
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| if not ( | ||
| bool(self.commit_msg_file) ^ bool(self.commit_msg) ^ bool(self.rev_range) | ||
| ): | ||
| sources = ( |
There was a problem hiding this comment.
The naming sources does not look straightforward to me. Currently, I do not have a better name for it. But we could at least add some comments to it.
There was a problem hiding this comment.
it's the amount/number of params provided, so something like params_amount or number_params_provided could be
|
Nice work! Looks great, I'm not much an user of |
|
As #255 is merged, we can close this one |
Description
As mentioned in #200, this PR makes
cz checkcan read message from pipe. In this mode, "--message" option is used.Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
String input from pipe can be read by
cz checkSteps to Test This Pull Request
echo COMMIT_MESSAGE | cz checkcat COMMIT_FILE | cz checkAdditional context
#200